refactor(language): a translation policy and a bound's side name the values they can be, rather than being a string - #354
Merged
Conversation
…values they can be, rather than being a string Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hdxai54hc4LwxFQBqMM8jF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
Re-opened against
main. #350 carried this same commit but was based onrefactor/literal-vocabularies, so merging it landed the change on that branch rather than onmain— #345 had already gone in as a squash. The branch is now rebased ontomainand holds one commit.Two more closed vocabularies that were open in the annotation.
_Step.policywas astrkeying_TRANSLATIONS, and_is_open'ssidewas astrkeying_OPEN— both are nowTranslationPolicyandBoundSide, and both tables are typed by them.Verified:
pixi run cion the rebased branch — lint, 1003 tests,mkdocs build --strict, 27 documents compiled. Each guard was checked by breaking it; output below.The guards, broken
A policy the table has no row for —
_Step(by, 'wrapp'):A misspelled bound side —
else 'uppper':What is not here
OperatorNameforOPERATOR_SPELLINGS/Format.operators/Walk.opis #352, stacked on this branch. It was split out because it costs 30 duplicated string literals next to the 30-row spelling table, and both directions are already covered by tests — so it can be turned down without taking these two with it.refactor/literal-vocabulariesnow holds a merge commit that is on no other branch. It is yours to delete when convenient; I did not touch it.