chore: make install.sh ASCII-safe for bash 3.2#5
Merged
Conversation
The installer put a Unicode ellipsis directly after $TAG/$APP. Under bash 3.2 (what macOS ships and 'curl | bash' runs) with set -u, the multibyte character was absorbed into the variable name, crashing on first run with 'TAG: unbound variable'. Replace all non-ASCII characters with ASCII. Verified end-to-end under bash 3.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the installer crashing with
TAG: unbound variableon first run. The script used a Unicode ellipsis right after$TAG/$APP; macOS bash 3.2 (whatcurl | bashuses) absorbs the multibyte char into the variable name underset -u. The script is now pure ASCII, verified end-to-end under bash 3.2 (downloads, mounts, installs, unquarantined). Typedchore:so it does not cut a release.