Automate matched real-call RTCP experiments - #8
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe realtime AudioSocket CLI now supports experiment-condition labels and optional AMI RTCP collection. Collector tasks attach to call sessions and stop during shutdown. Documentation describes matched call experiments, attribution limits, configuration, and troubleshooting. ChangesRTCP collection and experiment attribution
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Operator
participant audiosocket_realtime
participant RealtimeCallSession
participant AMI_RTCP_collector
participant observed_run
Operator->>audiosocket_realtime: enable --collect-rtcp
audiosocket_realtime->>AMI_RTCP_collector: start and bind after provider connection
audiosocket_realtime->>RealtimeCallSession: pass background_tasks
AMI_RTCP_collector->>observed_run: record and flush RTCP observations
RealtimeCallSession->>AMI_RTCP_collector: cancel and await on close
RealtimeCallSession->>observed_run: complete or fail run
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The first real Gemini call exposed barge-in evidence and an AGC transient, but it contained no RTP/RTCP observations. That made packet loss neither provable nor excludable. The previous manual collector workflow also required copying a run ID during an active call, which made the evidence gap easy to reproduce accidentally.
This change makes the transport evidence opt-in with one flag and binds it to the correct run lifecycle automatically.
Validation
ruff check .pytest -q— 323 passed, 4 skippednpm --prefix web run buildnpm --prefix web audit --audit-level=high— 0 vulnerabilitiesgit diff --checkOperator note
Automatic AMI collection supports one active test call at a time. The privacy-safe adapter deliberately discards Channel, address, and SSRC fields, so concurrent aggregate RTCP events cannot be attributed safely. Exact RTP sequence-gap proof still requires the library packet-observation adapter.
Summary by CodeRabbit