Improve asset rows rendering perf by 200%-300%. Partially enable concurrent mode#12611
Merged
mergify[bot] merged 5 commits intodevelopfrom Mar 24, 2025
Merged
Conversation
MrFlashAccount
requested review from
PabloBuchu,
indiv0 and
somebody1234
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
MrFlashAccount
added
CI: No changelog needed
MrFlashAccount
added
the
CI: Keep up to date
jdunkerley
removed
the
CI: Keep up to date
PabloBuchu
approved these changes
Mar 24, 2025
somebody1234
approved these changes
Mar 24, 2025
Contributor
somebody1234
left a comment
somebody1234
left a comment
There was a problem hiding this comment.
CR ✅ with note above. @MrFlashAccount feel free to mark as ready to merge
MrFlashAccount
added
the
CI: Ready to merge
farmaazon
pushed a commit
that referenced
this pull request
Mar 25, 2025
…urrent mode (#12611) This PR: 1. Removes no-op queries like `listUsers` and `listUserGroups` - they're not available for non-admins 2. Pulls labels query up to assets table 3. Pulls mutations off `AssetRows`. 4. Does a few little tweaks This improves updates for individual rows significantly faster (70ms baseline vs sub-15ms now)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR:
listUsersandlistUserGroups- they're not available for non-adminsAssetRows.This improves updates for individual rows significantly faster (70ms baseline vs sub-15ms now)
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.