Add 1Password CLI (op) integration as secret provider - #26
Merged
Conversation
Implements OnePasswordProvider and OnePasswordPlugin to support fetching
secrets from 1Password vaults using the `op` CLI. Secrets can be
referenced using the syntax ${op:vault/item#field}.
Supports two authentication methods:
- Pre-authenticated session (interactive): User runs `op signin` first
- Service account token (CI/CD): Via OP_SERVICE_ACCOUNT_TOKEN env var
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
llambeau
force-pushed
the
feature/secrets-improvements
branch
from
January 24, 2026 12:06
9f145ad to
f44b77f
Compare
llambeau
added a commit
that referenced
this pull request
Jul 17, 2026
The constructor runs top-level tasks through toIdentifedHash, which stamps each with synthesized `id`/`name` keys for runtime resolution. toJSON() returned those tasks verbatim, so the keys leaked into the serialized config. Since `emb config print` emits `toJSON()` output and TaskConfig has `additionalProperties: false`, the printed config failed its own re-validation with `unknown property 'id'`. Strip `id`/`name`/`component` from tasks at the serialization boundary, leaving `this.tasks` untouched for runtime consumers. `with()` still works — it re-runs toIdentifedHash on the cleaned tasks. Addresses REPORT.md finding #26. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements OnePasswordProvider and OnePasswordPlugin to support fetching secrets from 1Password vaults using the
opCLI. Secrets can be referenced using the syntax ${op:vault/item#field}.Supports two authentication methods:
op signinfirst