Enable integration with Apptools Undo/Redo#167
Merged
Conversation
corranwebster
changed the title
Contributor
Author
|
@jwiggins This is ready for review. |
Member
There was a problem hiding this comment.
I'm guessing that 'position' here should be 'zoom level' or something similar.
Member
|
Thanks for writing this! |
Member
|
What do you think about moving the unit tests to |
Member
|
@corranwebster: Will you have time to look at this soon? I'd like to make a release of Enable soon and I want this feature to be part of it. |
Conflicts: CHANGES.txt
Contributor
Author
|
OK - assuming build goes OK, I think everything is addressed. |
Member
|
#173 should fix the build problems here. I'm otherwise ready to merge. |
…able into feature/apptools-undo-tools
Contributor
Author
|
Everything looks like it is passing. Will merge. |
corranwebster
added a commit
that referenced
this pull request
Mar 23, 2015
Enable integration with Apptools Undo/Redo
Member
|
Thanks again for all the work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides basic infrastructure and sample implementations of Tools that integrate with the Apptools Undo/Redo infrastructure. This is intended to be used as an (optional) replacement for the ad-hoc "tool history" implementations that don't play nicely with wider application undo/redo functionality.
The motivation for this came when working on product code that uses Apptools Undo/Redo in a lot of places, but we were unable to easily add Chaco-based operations to the Undo/Redo stack, which led to an awkward user experience.
It also adds a
DemoApplicationclass for demos that need more than the usualDemoFrameprovides (like access to menus, toolbars, status bars, etc.).MoveToolimplementation.MoveTool.undoable attribute change tool - such as change background color)