Simple Button Tool#168
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
Any reason for the double backticks here?
Member
|
Just a few minor nitpicks. Other than that this looks nice. |
Contributor
Author
|
Took me a while to have the spare cycles to look at this, but I've fixed issues. However it looks like we are getting failures in the build due to something wrong with PIL. I think they are unrelated. |
Member
|
Thanks for the updates! I'm not going to count the Travis failures against this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a common tool that can be used whenever we want something to be "clickable" or "togglable". Probably of significant utility in Chaco.
Has tests and documentation.
Ready for review.