Skip to content

Cleanup setup and requirements#178

Merged
itziakos merged 19 commits into
masterfrom
update-requirements
Mar 28, 2015
Merged

Cleanup setup and requirements#178
itziakos merged 19 commits into
masterfrom
update-requirements

Conversation

@itziakos

Copy link
Copy Markdown
Member

This PR tries to fix the requirements for kiva and enable and at the same time clean-up the travis-ci build

@itziakos itziakos changed the title [WIP] Update requirements Cleanup setup and requirements Mar 27, 2015
@itziakos

Copy link
Copy Markdown
Member Author

Please note that now the PR tests take only 7 minutes instead of 12-14.

Comment thread enable/__init__.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used here

@jwiggins

Copy link
Copy Markdown
Member

Other than that unused import I'm 👍 on this PR

@jwiggins

Copy link
Copy Markdown
Member

Go ahead and merge as soon as Travis gives the OK. I'm going offline for a bit.

@itziakos

Copy link
Copy Markdown
Member Author

Ok we now pass the setup.py import and we arrive at a new issue which now is the result of the interaction between setuptools and numpy.distutils. It looks that if any packages are in the install_requires list, we get an out of memory error when one of the required packages is installed.

So, that is why commit 14e11492 fails, because it will cause the required packages to be downloaded by the combined setuptools/numpy.distutils setup.py. I have been able to replicate the behaviour locally.

@itziakos

Copy link
Copy Markdown
Member Author

So it looks that the last version of setuptools that work is 9.1

itziakos added a commit that referenced this pull request Mar 28, 2015
@itziakos itziakos merged commit c7ff72f into master Mar 28, 2015
@itziakos itziakos deleted the update-requirements branch March 28, 2015 00:27
@jwiggins jwiggins mentioned this pull request Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants