Skip to content

Multiple build environments#195

Merged
jwiggins merged 32 commits into
masterfrom
multiple-build-environments
May 11, 2015
Merged

Multiple build environments#195
jwiggins merged 32 commits into
masterfrom
multiple-build-environments

Conversation

@itziakos

@itziakos itziakos commented May 8, 2015

Copy link
Copy Markdown
Member

This PRs adds support for multiple build environments. The test coverage changes are not expected to change since there are not many gui toolkit specific tests

@itziakos

itziakos commented May 9, 2015

Copy link
Copy Markdown
Member Author

Added support for pillow/pil builds. There is a strange problem with nose and expectedFailure decorated methods. Need to investigate.

@itziakos

itziakos commented May 9, 2015

Copy link
Copy Markdown
Member Author

This PR is ready for review.

Comment thread travis_setup.sh Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this isn't needed any longer?

@jwiggins

Copy link
Copy Markdown
Member

Any reason why the setup script can't be named with a leading .? That's how the install scripts were named before. I noticed several commits where you kinda bounced around trying to find something that Travis would accept.

Other than some pretty minor feedback, I'm 👍 on this. Hopefully this will be a bit more stable than the earlier accommodations made for PIL/pillow. Oh, and actually testing WX is a nice touch too 😉

@itziakos

Copy link
Copy Markdown
Member Author

Any reason why the setup script can't be named with a leading .? That's how the install scripts were named before. I noticed several commits where you kinda bounced around trying to find something that Travis would accept.

it looked to me weird that the scripts where hidden, so I changed that.

@itziakos

Copy link
Copy Markdown
Member Author

Other than some pretty minor feedback, I'm 👍 on this. Hopefully this will be a bit more stable than the earlier accommodations made for PIL/pillow. Oh, and actually testing WX is a nice touch too 😉

In general, I think it is a better build setup. Please note however that it does not look that we are testing much or WX or QT code of enable. We need to increase the test coverage.

@jwiggins

Copy link
Copy Markdown
Member

WTF. pushd/popd doesn't work when you execute a script with sh? Perhaps /bin/sh is not bash on Travis?

@WarrenWeckesser

Copy link
Copy Markdown
Contributor

Ubuntu uses dash for /bin/sh, and dash does not have pushd and popd.

@itziakos

Copy link
Copy Markdown
Member Author

Ok, I reverted the change, it is not that bad to use cd

@jwiggins

Copy link
Copy Markdown
Member

Thanks @itziakos! :shipit:

jwiggins added a commit that referenced this pull request May 11, 2015
@jwiggins jwiggins merged commit d32de21 into master May 11, 2015
@jwiggins jwiggins deleted the multiple-build-environments branch May 11, 2015 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants