Skip to content

Fix for build issues#230

Merged
corranwebster merged 8 commits into
masterfrom
fix/setup-build
May 20, 2016
Merged

Fix for build issues#230
corranwebster merged 8 commits into
masterfrom
fix/setup-build

Conversation

@corranwebster

Copy link
Copy Markdown
Contributor

Should fix #229

@jwiggins

Copy link
Copy Markdown
Member

Uhh... you're reverting a change that you made: 8f3ff1b

Do you remember why you made that change to begin with?

@jwiggins

Copy link
Copy Markdown
Member

Well... I think the Travis failure answered the "why".

Odd. 😒

@corranwebster

Copy link
Copy Markdown
Contributor Author

Very odd - it looks like pip install wants one thing and setup.py develop wants the other.

Mind you, setup.py develop is dodgy when combined with 2to3.

@corranwebster

Copy link
Copy Markdown
Contributor Author

OK, so problem is that if you don't do the builder swap then the integration tests are not updated to Python 3 - but doing the builder swap is not the right thing to do, I think. I'd say that probably the best option is to make the integration tests work on both 2 and 3 with the same codebase.

@corranwebster

Copy link
Copy Markdown
Contributor Author

And the code in the integration tests is horrible, so I've folded them into the Kiva test suites instead. They may need some tweaking to run under Python 3.

@corranwebster

Copy link
Copy Markdown
Contributor Author

OK - back to builds working. @jwiggins or @itziakos if you have a chance to double-check this it would be good. I haven't checked that pip install . works properly yet, and won't have a chance until this evening.

@jwiggins

Copy link
Copy Markdown
Member

I just tested pip install . on a fresh Python 3.4 virtualenv. It worked. I'm 👍 on this PR

@corranwebster

Copy link
Copy Markdown
Contributor Author

Thank you.

@corranwebster corranwebster merged commit c685c44 into master May 20, 2016
@corranwebster corranwebster deleted the fix/setup-build branch May 20, 2016 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python setup.py install fails to install kiva.agg

2 participants