Call GetCurrentPoint as intended#268
Merged
Merged
Conversation
The CompiledPath class in the kiva SVG renderer backend already had a workaround for the `get_current_point` method being absent. It only needed to be connected.
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
===========================================
- Coverage 53.53% 35.44% -18.09%
===========================================
Files 119 205 +86
Lines 12446 18799 +6353
Branches 1787 2627 +840
===========================================
+ Hits 6663 6664 +1
- Misses 5358 11700 +6342
- Partials 425 435 +10
Continue to review full report at Codecov.
|
Member
|
LGTM. |
Member
Author
|
Thanks for reviewing! |
mdickinson
pushed a commit
that referenced
this pull request
May 8, 2017
(cherry picked from commit 359c2f9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #267
The
CompiledPathclass in the kiva savage backend already had a workaround for theget_current_pointmethod being absent. It only needed to be connected.