Ensure integer sizes#269
Merged
Merged
Conversation
This fixes test failures with the null backend and numpy 1.12 This also moves the monkeypatched init() to the proper place. It was made a monkeypatch a very long time ago to work around a SWIG issue that has long since been resolved.
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
=======================================
Coverage 35.44% 35.44%
=======================================
Files 205 205
Lines 18799 18799
Branches 2627 2627
=======================================
Hits 6664 6664
Misses 11700 11700
Partials 435 435Continue to review full report at Codecov.
|
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numpy 1.12 completes the deprecation of floats as shapes. The
GraphicsContext()constructor permits such floats, so we coerce internally at the last possible moment.This also fixes the skip logic for an unrelated test so that I'd have a clean test suite.
This should fix the test failure in enthought/chaco#342 in the one Travis environment that is using numpy 1.12.