Skip to content

Fix code which triggered DeprecationWarnings#343

Merged
jwiggins merged 2 commits into
masterfrom
fix/deprecation-warnings
May 27, 2019
Merged

Fix code which triggered DeprecationWarnings#343
jwiggins merged 2 commits into
masterfrom
fix/deprecation-warnings

Conversation

@jwiggins

Copy link
Copy Markdown
Member

Fixes #339

@jwiggins

Copy link
Copy Markdown
Member Author

Note that piltostring is just a wrapper around Image.tobytes (or Image.tostring when not using Pillow). All of the fromstring -> frombuffer conversions are passing the output of piltostring.

@codecov-io

codecov-io commented May 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #343 into master will not change coverage.
The diff coverage is 14.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   33.94%   33.94%           
=======================================
  Files         206      206           
  Lines       18290    18290           
  Branches     2414     2414           
=======================================
  Hits         6209     6209           
  Misses      11688    11688           
  Partials      393      393
Impacted Files Coverage Δ
enable/component.py 55.76% <0%> (ø) ⬆️
enable/savage/svg/document.py 27.04% <0%> (ø) ⬆️
enable/scrolled.py 23.52% <0%> (ø) ⬆️
enable/tools/viewport_zoom_tool.py 49.54% <0%> (ø) ⬆️
enable/container.py 53.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d225b6f...14c6ab9. Read the comment docs.

@jvkersch jvkersch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread enable/container.py Outdated
@jwiggins jwiggins force-pushed the fix/deprecation-warnings branch from f615128 to 14c6ab9 Compare May 27, 2019 16:03
@jwiggins jwiggins merged commit 768e791 into master May 27, 2019
@jwiggins jwiggins deleted the fix/deprecation-warnings branch May 27, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeprecationWarning triggered by downstream package tests

3 participants