Add more Qt mouse button names#345
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=======================================
Coverage 33.94% 33.94%
=======================================
Files 206 206
Lines 18290 18290
Branches 2414 2414
=======================================
Hits 6209 6209
Misses 11688 11688
Partials 393 393
Continue to review full report at Codecov.
|
Member
Author
|
@corranwebster Care to comment on the names I picked for the buttons? |
Contributor
|
Names look fine to me - I've never had a 5 button mouse, but that seems consistent usage with searches. |
corranwebster
approved these changes
Jun 3, 2019
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334