Update unittest import#349
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 32.93% 32.93%
=======================================
Files 206 206
Lines 18290 18290
Branches 2414 2414
=======================================
Hits 6024 6024
Misses 11880 11880
Partials 386 386Continue to review full report at Codecov.
|
jwiggins
approved these changes
Jun 5, 2019
jwiggins
left a comment
jwiggins
left a comment
Member
There was a problem hiding this comment.
LGTM. I even double checked by grepping for any missed files.
import it from the standard library instead of importing it via traits modified: enable/tests/qt4/scrollbar_test.py modified: enable/tests/tools/apptools/commands_test_case.py modified: enable/tests/tools/apptools/move_command_tool_test_case.py modified: enable/tests/tools/apptools/resize_command_tool_test_case.py modified: enable/tests/tools/apptools/undo_tool_test_case.py modified: enable/tests/tools/button_tool_test_case.py modified: kiva/tests/test_agg_drawing.py modified: kiva/tests/test_cairo_drawing.py modified: kiva/tests/test_gl_drawing.py modified: kiva/tests/test_graphics_context.py modified: kiva/tests/test_image.py modified: kiva/tests/test_pdf_drawing.py modified: kiva/tests/test_ps_drawing.py modified: kiva/tests/test_qpainter_drawing.py modified: kiva/tests/test_svg_drawing.py
rahulporuri
force-pushed
the
fix/traits-unittest-tools
branch
from
9435b7a to
3c49c81
Compare
Contributor
Author
|
I rebased this branch on top of master to fix the merge conflicts. |
jwiggins
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import it from the standard library instead of importing it via
traits.