Skip to content

Fix paths to static files.#358

Merged
jwiggins merged 1 commit into
masterfrom
doc/fix-paths-to-static-files
Jun 27, 2019
Merged

Fix paths to static files.#358
jwiggins merged 1 commit into
masterfrom
doc/fix-paths-to-static-files

Conversation

@mdickinson

@mdickinson mdickinson commented Jun 17, 2019

Copy link
Copy Markdown
Member

The html_logo and html_favicon paths should be relative to the configuration directory. A Sphinx build (without the enthought-sphinx-theme) currently produces:

copying static files... WARNING: logo file 'e-logo-rev.png' does not exist
WARNING: favicon file 'et.ico' does not exist
done

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   32.91%   32.91%           
=======================================
  Files         206      206           
  Lines       18303    18303           
  Branches     2415     2415           
=======================================
  Hits         6024     6024           
  Misses      11893    11893           
  Partials      386      386

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd09efa...a837d3f. Read the comment docs.

@jwiggins

Copy link
Copy Markdown
Member

Should this go into the 4.8.0 release?

@jwiggins jwiggins merged commit bf539a8 into master Jun 27, 2019
@jwiggins jwiggins deleted the doc/fix-paths-to-static-files branch June 27, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants