Fix deprecation warnings due to escape characters#371
Merged
Conversation
Member
Right, these are annoying to track down because (unlike most other warnings) they're triggered at compile time - i.e., .pyc-file generation time. If you remove the .pyc files and try again, you should see the warnings reappear. |
Member
|
FWIW, |
Member
|
Here's what I see from |
Contributor
Author
|
That makes sense. Thanks. I can go over all these occurrences and update them all as it is well within scope for this PR, then request review again. Does this sound good? |
Member
SVGTM |
mdickinson
approved these changes
Nov 6, 2019
Contributor
Author
|
Thank you! Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes deprecation warnings while running a test suite in a downstream project depending on enable.
It is not easy to pin point exactly where this gets trigger: I believe this is triggered by some import side-effects and the warning only appears once after every time my Python environment is rebuilt.
For example:
Running the command again does not trigger the warnings.