FIX: Make font style- and stretch- check case insensitive

[achabotl]

This makes style and stretch case insensitive in
kiva.fonttools.font_manager.ttfFontProperty. The case sensitivity led
to font styles not being properly detected on (at least) macOS.

The checks on filename were already case insensitive.

I'm not sure how to test this. There's a test in fonttools, but it would required modifying the test .ttf file and I didn't know how to fix it. Help would be appreciated.

enable/kiva/fonttools/tests/test_font_manager.py

Line 53 in 6cf525c

def test_font(self):

Here's a small test sample and an example that it works

from kiva.fonttools import Font
from kiva.image import GraphicsContext
from kiva.constants import ITALIC, BOLD

gc = GraphicsContext((200, 200))

f = Font('', size=24)
print("Top: ", f.findfont())
gc.set_font(f)
gc.set_text_position(30, 150)
gc.show_text("Hello World")

f = Font('Georgia', size=24)
print('2nd', f.findfont())
gc.set_font(f)
gc.set_text_position(30, 110)
gc.show_text("Hello World")

f = Font('Georgia', size=24, style=ITALIC)
print('3rd', f.findfont())
gc.set_font(f)
gc.set_text_position(30, 70)
gc.show_text("Hello World")

f = Font('Georgia', size=24, style=BOLD)
print('4th', f.findfont())
gc.set_font(f)
gc.set_text_position(30, 30)
gc.show_text("Hello World")

gc.save('text.png')

Fixes: #404
Also addresses part of #391.

[achabotl]

It looks like I can edit the font with the free and open source FontForge app.

[achabotl]

The test failures are unrelated to the change.

• Environment: RUNTIME=3.5, TOOLKITS=null pyqt pyqt5: NotImplementedError: the null pyface.ui.null backend doesn't implement util.gui_test_assistant:GuiTestAssistant
• Environment: RUNTIME=3.6, TOOLKITS=null pyqt pyqt5: NotImplementedError: the null pyface.ui.null backend doesn't implement util.gui_test_assistant:GuiTestAssistant
• Environment: RUNTIME=3.6, TOOLKITS=wx: RuntimeError: Python 3.6, toolkit wx, and pillow pillow not supported by test environments

[kitchoi]

Rebuilding CI now that #424 is merged... 🤞

[kitchoi]

(Merged master in to get the latest CI changes)

[codecov-io]

Codecov Report

Merging #405 (ed8198d) into master (55fc728) will increase coverage by 1.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   28.96%   30.51%   +1.54%     
==========================================
  Files         206      206              
  Lines       18245    17853     -392     
  Branches     2466     2461       -5     
==========================================
+ Hits         5284     5447     +163     
+ Misses      12634    12068     -566     
- Partials      327      338      +11     

Impacted Files	Coverage Δ
kiva/fonttools/font_manager.py	50.44% <100.00%> (-0.30%)	⬇️
kiva/image.py	85.71% <0.00%> (-14.29%)	⬇️
enable/coordinate_box.py	31.15% <0.00%> (-1.50%)	⬇️
enable/primitives/box.py	33.33% <0.00%> (-1.29%)	⬇️
enable/tools/move_tool.py	82.75% <0.00%> (-1.12%)	⬇️
enable/tools/apptools/command_tool.py	84.61% <0.00%> (-1.10%)	⬇️
enable/qt4/constants.py	89.47% <0.00%> (-1.01%)	⬇️
enable/tools/base_drop_tool.py	76.66% <0.00%> (-0.76%)	⬇️
enable/interactor.py	84.00% <0.00%> (-0.62%)	⬇️
kiva/pdfmetrics.py	19.19% <0.00%> (-0.61%)	⬇️
... and 100 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55fc728...ed8198d. Read the comment docs.

[jwiggins]

LGTM

[achabotl]

Thanks for the fix @kitchoi, sorry for not being responsive on this one. I had forgotten about this PR. 😞

[kitchoi]

@achabotl No worries, thank you for the fix!