Fix test failures when run against TraitsUI 7.1.0#446
Merged
Conversation
kitchoi
commented
Nov 24, 2020
| "Test not working on the 'null' backend" | ||
| ) | ||
|
|
||
| skip_if_not_qt = unittest.skipIf(not is_qt(), "Test only for qt") |
Contributor
Author
There was a problem hiding this comment.
I took the opportunity to rename qt4 to just qt.
jwiggins
approved these changes
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #425
This PR reimplemented a few trivial test utility functions to be used within Enable and Kiva such that tests no longer import from private modules of TraitsUI. See also #443 on to what extent enable/kiva should depend on Pyface/TraitsUI. Dependency is a worse enemy to repeating oneself. The test utilities are so simple that reimplementing them is a cheap cost to enable looser coupling among the packages.