Fix missing new dependencies in cron job#448
Merged
Merged
Conversation
kitchoi
commented
Nov 24, 2020
| "pip install --force-reinstall --no-dependencies " + ROOT | ||
| ) | ||
| execute([install_local], parameters) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The original location for this command is probably okay as none of apptools, pyface, traitsui and traits are going to install enable/kiva. Nevertheless I find it more reassuring that it is moved down here as safe measures.
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 28.95% 28.95%
=======================================
Files 206 206
Lines 18252 18252
Branches 2466 2466
=======================================
Hits 5284 5284
Misses 12641 12641
Partials 327 327 Continue to review full report at Codecov.
|
rahulporuri
approved these changes
Nov 24, 2020
rahulporuri
left a comment
rahulporuri
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I tested this locally and it works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #447
This is band-aid to the complicated setup we have so that the cron job on Travis can still run. This will be refreshed again when we move to GitHub Actions, as we are making the move in other ETS projects as well.