Replace use of tempfile.mktemp with tempfile.NamedTemporaryFile #456
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
=======================================
Coverage 28.96% 28.96%
=======================================
Files 206 206
Lines 18245 18245
Branches 2466 2466
=======================================
Hits 5284 5284
Misses 12634 12634
Partials 327 327 Continue to review full report at Codecov.
|
jwiggins
reviewed
Dec 2, 2020
jwiggins
left a comment
jwiggins
left a comment
Member
There was a problem hiding this comment.
All of these changes seem to ignore the "temporary" part of NamedTemporaryFile
jwiggins
reviewed
Dec 2, 2020
jwiggins
approved these changes
Dec 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #398
This PR replaces all uses of
tempfile.mktempas it is deprecated and unsafe.