Require wx CI job to pass#459
Merged
Merged
Conversation
kitchoi
commented
Dec 2, 2020
|
|
||
| # create and mock a mouse wheel event | ||
| wx_event = wx.MouseEvent(mouseType=wx.wxEVT_MOUSEWHEEL) | ||
| wx_event = wx.MouseEvent(wx.wxEVT_MOUSEWHEEL) |
Contributor
Author
There was a problem hiding this comment.
The argument name was changed to mouseEventType. I could use named argument here too.
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 28.96% 30.33% +1.37%
==========================================
Files 206 206
Lines 18245 18245
Branches 2466 2466
==========================================
+ Hits 5284 5534 +250
+ Misses 12634 12371 -263
- Partials 327 340 +13
Continue to review full report at Codecov.
|
Contributor
Author
|
I forgot about the wx job on Appveyor :( Lines 16 to 19 in 77cb194 And the job is failing, I will open an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the few test errors for the wx test suite and change the CI configuration such that wx is required to pass.
I did not fix #458, I merely turned the assertion into an "expected failure" (but without using unittest's expectedFailure, which allows unexpected errors to pass and should not be used on anything that might last for any prolonged period of time).