Skip to content

Make kiva_explorer a popup#510

Merged
aaronayres35 merged 2 commits into
masterfrom
make-kiva-explorer-popup
Dec 21, 2020
Merged

Make kiva_explorer a popup#510
aaronayres35 merged 2 commits into
masterfrom
make-kiva-explorer-popup

Conversation

@aaronayres35

Copy link
Copy Markdown
Contributor

fixes #509

This is very short PR which simply changes kiva_explorer to come up as a popup rather than trying to compress it into the demo tab of the etsdemo application. All this requires is a change to use the magic named popup

@jwiggins jwiggins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a comment explaining the magic naming. Otherwise LGTM

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #510 (8a5cdc7) into master (2ae4f5c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   30.71%   30.71%           
=======================================
  Files         210      210           
  Lines       17840    17840           
  Branches     2454     2454           
=======================================
  Hits         5479     5479           
  Misses      12028    12028           
  Partials      333      333           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae4f5c...10f0e43. Read the comment docs.

@jwiggins jwiggins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@aaronayres35 aaronayres35 merged commit 6b73f5b into master Dec 21, 2020
@jwiggins jwiggins deleted the make-kiva-explorer-popup branch December 21, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Kiva Explorer demo a popup

3 participants