Skip to content

Remove outdated/unnecessary files#521

Merged
rahulporuri merged 9 commits into
masterfrom
rahulporuri-patch-2
Dec 31, 2020
Merged

Remove outdated/unnecessary files#521
rahulporuri merged 9 commits into
masterfrom
rahulporuri-patch-2

Conversation

@rahulporuri

@rahulporuri rahulporuri commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

There are a number of outdated/unnecessary files in the git source which can be removed. This PR removes some (not all) of them.

  • kiva/agg/implementation_notes.txt has been moved to docs/kiva/agg
  • enable/enable.txt has been removed
  • enable/pyglet_backend/notes.txt has been removed
  • enable/savage/compliance/w3c_svg_11 and enable/savage/compliance/w3c_svg_11/notes.txt have been removed. The enable/savage/complaince/README has been updated to provide the relevant information
  • enable/savage/readme.txt has been removed
  • kiva/fonttools/tests/data/source.txt has been moved to the top level and renamed. At the same time, kiva/fonttools/tests/data/fonttools_LICENSE.txt has been moved to the top level. These files are now included in the source distribution via changes in the MANIFEST file.
  • kiva/agg/src/swig_questions.txt has been removed
  • kiva/agg/src/todo.txt has been removed.

Now that we have proper documentation, we have no need
for this file.
@codecov-io

codecov-io commented Dec 30, 2020

Copy link
Copy Markdown

Codecov Report

Merging #521 (7e2b2ec) into master (5834fb8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   35.16%   35.16%           
=======================================
  Files         210      210           
  Lines       17840    17840           
  Branches     2454     2454           
=======================================
  Hits         6274     6274           
  Misses      11161    11161           
  Partials      405      405           
Impacted Files Coverage Δ
kiva/api.py 100.00% <0.00%> (ø)
enable/api.py 93.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5834fb8...7e2b2ec. Read the comment docs.

@jwiggins jwiggins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about any of these files?

enable/pyglet_backend/notes.txt
enable/savage/compliance/w3c_svg_11/notes.txt
enable/savage/readme.txt
docs/kiva/agg/interface.txt
kiva/agg/freetype2/docs/raster.txt
kiva/agg/freetype2/docs/formats.txt
kiva/agg/implementation_notes.txt
kiva/agg/src/todo.txt
kiva/agg/src/swig_questions.txt
kiva/fonttools/tests/data/source.txt

Sai Rahul Poruri added 8 commits December 31, 2020 09:46
	modified:   enable/savage/compliance/README
	deleted:    enable/savage/compliance/w3c_svg_11/notes.txt
and move the information into a ticket on github

	deleted:    enable/savage/readme.txt
the todo file contained a list of tasks to do, tasks done and issues.
it is not clear how uptodate the contents of the file actually are so at
the moment, we have chosen to remove it from the source tree.

	deleted:    kiva/agg/src/todo.txt
	renamed:    kiva/agg/implementation_notes.txt -> docs/kiva/agg/implementation_notes.txt
	modified:   docs/kiva/agg/implementation_notes.txt
Again, we are not sure how uptodate this document is and how relevant
the questions (or answers to the questions) are at this moment

	deleted:    kiva/agg/src/swig_questions.txt
	modified:   MANIFEST.in
	renamed:    kiva/fonttools/tests/data/source.txt -> font_LICENSE.txt
	renamed:    kiva/fonttools/tests/data/fonttools_LICENSE.txt -> fonttools_LICENSE.txt
again, we are not sure how uptodate the document is and how useful any
of the information in the document is.

	deleted:    enable/pyglet_backend/notes.txt
@rahulporuri rahulporuri changed the title Remove outdated/unnecessary file Remove outdated/unnecessary files Dec 31, 2020
@rahulporuri rahulporuri requested a review from jwiggins December 31, 2020 10:22
@rahulporuri

Copy link
Copy Markdown
Contributor Author

docs/kiva/agg/interface.txt

It looked like useful information so i kept this around

kiva/agg/freetype2/docs/raster.txt
kiva/agg/freetype2/docs/formats.txt

It looks like they're coming from freetype2 source and are not something we added - so i kept them around.

I didn't remove them

kiva/agg/implementation_notes.txt

I moved this into docs/kiva/agg as it looked like useful documentation.

@rahulporuri rahulporuri merged commit 573469c into master Dec 31, 2020
@rahulporuri rahulporuri deleted the rahulporuri-patch-2 branch December 31, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants