Add cron job to GitHub Actions and expand extras_require#544
Merged
Conversation
kitchoi
commented
Jan 14, 2021
| # (enthought/enable#360) | ||
| os: [ubuntu-18.04] | ||
| toolkit: ['pyside2', 'wx'] | ||
| python-version: [3.8] |
Contributor
Author
There was a problem hiding this comment.
I tried the combination of Python 3.9 and Ubuntu 20, but there aren't a prebuilt wheel for wxPython, which means we will have to build from source (take a long time!). But then I haven't tried bumping Python version again for Ubuntu 18.
I did not use Ubuntu 16, as an attempt to be as close to the latest as possible, and also to be different from the per-PR CI job (using Ubuntu 16) to expand coverage.
rahulporuri
approved these changes
Jan 14, 2021
rahulporuri
left a comment
Contributor
There was a problem hiding this comment.
LGTM with one question.
Contributor
|
still LGTM |
Contributor
Author
|
Thank you @rahulporuri |
Contributor
|
still LGTM |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a cron job to the GitHub Actions workflow.
Different from the cron job currently setup on Travis which uses EDM, this cron job is setup to install everything from
pip.This exercise also helps flush out missing dependency declaration in
setup.py, which isn't used byci/edmtool.py. With that, theextras_requiredeclarations for optional dependencies is expanded here so that CI setup can callpip install .[flag,...]. This will further benefit package distributors who will be looking for these declarations when they build enable.As the names of the optional dependencies are tied to the cron job setup, I keep these two changes in the same PR.
Since tests on optional features are skipped if the optional dependency is absent (apart from the ones on SVG, see #543), I checked the CI job output to look out for unexpected skips.
Note to reviewer
The current trigger is
on: push, for testing purposes. Once the reviewer is happy with the change, I will switch the event trigger to:and request one more review again before merging.