Add null to the list of toolkits tested on GitHub Actions#548
Merged
Conversation
rahulporuri
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the null GUI toolkit to the test matrix. This will catch most omissions to declare GUI dependencies in tests (e.g. tests with
skip_if_nulldecorator).Note that CI setup on Appveyor Windows does tests against null backend and I have not added it here.
I am wondering if it is enough to test null backend on one platform only (motivated by a desire to conserve free resources shared among OSS community). If this is good enough, I think we have all the pieces from Travis/Appveyor ported to GitHub Actions after this PR. If not, it is also easy for me to extend the matrix for Windows to include the null backend.