Provide the right path to the version file on windows#563
Merged
Conversation
On the main branch, the _version.py files dont get generated in enable and kiva - because of the path provided to write_version_py function. The changes made here enable the generation of the version file - which also fixes an issue where documentation build is broken on windows because of the lack of the version file. modified: setup.py
win/not win modified: setup.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the main branch, the
_version.pyfiles don't get generated inenableandkiva- because of the path provided towrite_version_pyfunction. The changes made here enable the generation of the version file - which also fixes an issue where documentation build is broken on windows because of the lack of the version file.This is the right fix for the problem I was trying to solve in #519 .