Clean up some of the agg tests#573
Merged
Merged
Conversation
jwiggins
commented
Feb 5, 2021
| number = 10 ** i | ||
| time = timer.timeit(number) | ||
| if time > 0.2: | ||
| if time > 0.02: |
Member
Author
There was a problem hiding this comment.
Also these tests are now 10x faster
rahulporuri
approved these changes
Feb 8, 2021
rahulporuri
left a comment
rahulporuri
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I'm not sure why test_image3 existed in the first place but it does look like there is no useful information that can be extracted from there.
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting a bit sick of images getting dumped into the current directory after each
kivatest run, so this PR does away with that. These old tests are of dubious use, but I'm leaving them in because they at least exercise some code paths.