Celiagg's clip_to_rect() should respect the transform matrix#592
Merged
Conversation
rahulporuri
approved these changes
Feb 19, 2021
rahulporuri
left a comment
rahulporuri
left a comment
Contributor
There was a problem hiding this comment.
LGTM but can you find time to add a regression test?
Member
Author
|
I'll see what I can do |
jwiggins
force-pushed
the
fix/celiagg-clipping
branch
from
1f64531 to
af86ce8
Compare
Member
Author
|
Thanks for the review |
jwiggins
added a commit
that referenced
this pull request
Feb 19, 2021
jwiggins
added a commit
that referenced
this pull request
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the exploration for #591, I discovered that
clip_to_rectshould respect the current transformation and the celiagg backend was not doing this.Fixes #304 (as a side effect of adding unit tests for celiagg)