Fix backspacing wx textbox when there is selected text#1193
Merged
Conversation
kitchoi
commented
Sep 4, 2020
…erent platforms - not necessary for the purpose of this test.
kitchoi
commented
Sep 4, 2020
| textbox.SetValue("ABCDE") | ||
| textbox.SetSelection(0, 4) | ||
| # sanity check | ||
| self.assertEqual(textbox.GetStringSelection(), "ABCD") |
Contributor
Author
There was a problem hiding this comment.
Pedantic: This is not really a test objective so if the setup is not what we expect, we should raise a different exception to cause the test to "error", not to "fail". I am not a purist and the comment explains the intent of this assertion already so I am going to leave it here. Happy to remove it too if others find this confusing.
kitchoi
requested review from
aaronayres35 and
rahulporuri
and removed request for
aaronayres35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the implementation of
KeyClick("Backspace")on wx.TextCtrl when there is already some selected text.For reference, we could not get
wx.TextCtrl.EmulateKeyPressto emulate backspace on Windows, hence we had to emulate it ourselves. See #1184 and this discussion on wxPython forum.