test(versioncheck): isolate the install-probe env and tag the unix-only tests

[Soph]

https://entire.io/gh/entireio/cli/trails/1257

Two test-hygiene items found reviewing #2217, which merged while this was being written — so this targets main rather than stacking. Test-only: no production code changes.

1. The unix table test read the host's mise roots

isolateWindowsInstallEnv clears MISE_INSTALLS_DIR and MISE_DATA_DIR, but it lives in versioncheck_windows_test.go, so the unix table test never got the fix:

MISE_INSTALLS_DIR=/usr/local go test ./cmd/entire/cli/versioncheck/ -run TestUpdateCommandForCurrentBinary_Unix
--- FAIL: .../unknown_path_stable_falls_back_to_stable_curl_command
    UpdateCommandForCurrentBinary() = "mise upgrade entire", want "curl -fsSL https://entire.io/install.sh | bash"
--- FAIL: .../unknown_path_nightly_falls_back_to_nightly_curl_command

MISE_INSTALLS_DIR is the only probe variable whose value becomes a root verbatim — miseRoots returns it as-is, while MISE_DATA_DIR gets installs appended and scoopRoots appends apps to all four of its inputs. That mandatory extra segment is what stops the others prefixing an arbitrary path, and it is also why no value of SCOOP could reproduce the Windows half of the finding this fell out of: SCOOP=C:\tools yields the root c:/tools/apps/, which does not prefix c:/tools/cli/entire.exe.

So the exposed rows are exactly the two whose expectation is the fallback — the ones asserting that no probe matched — and one variable reaches them. The brew rows are immune by probe order, and the executable error row returns before the probe loop.

Fix: the two Setenv calls move into an untagged isolateMiseInstallEnv that both platforms share, with isolateWindowsInstallEnv wrapping it and adding Scoop's, so the pair cannot drift again.

Env	Before	After
MISE_INSTALLS_DIR=/usr/local	2 rows FAIL	pass
MISE_DATA_DIR=/usr	pass (needs an installs/ segment)	pass
MISE_INSTALLS_DIR=usr/local	pass (normalizeInstallRoot rejects relative)	pass

CI is unaffected either way — no runner sets these. It is the developer-box run that lies, with a message pointing at the code under test and no hint that the environment caused it.

2. Three CheckAndNotify tests were untagged but unix-only

TestCheckAndNotify_BrewSkipUntilNextVersionCachesLatest, ..._MiseSkipUntilNextVersionCachesLatest and ..._InstallerFailureKeepsCacheFresh all assert what happens after maybeAutoUpdate reaches the prompt — that chooseUpdate's answer lands in the cache as SkippedVersion, or that the Try again later running: hint prints. On Windows maybeAutoUpdate returns autoUpdateActionSkip before any of that, so all three fail on a Windows host. Confirmed by building the package with installerAutoRuns flipped to false.

CI cannot see it: test-windows selects by name (-run '(Windows|MSYS)') and none of these match. The previous escape hatch was the goos variable seam and its pinNonWindowsGOOS helper, which #2217 removed — correctly — leaving these three as the callers it did not follow up. A build tag is now the only way to express what they need.

They move to versioncheck_unix_test.go alongside the existing unix-only CheckAndNotify coverage, and brewUpgradeCmd goes with them since brew is a unix-only probe here. brewCaskPath stays untagged: TestCheckAndNotify_SkipsVersionMarkedSkipped still uses it and is genuinely platform-agnostic, because CheckAndNotify returns on the skipped version before any installer is consulted.

Verified with go list that the Windows test build now contains only autoupdate_windows_test.go, fixture_test.go, versioncheck_test.go and versioncheck_windows_test.go.

Known gap, deliberately not closed here

Nothing asserts the Windows side of the same contract — that CheckAndNotify does not cache a skip there, which is the deliberate "the nudge returns every 24h until they update" behaviour maybeAutoUpdate documents. That wants a new windows-tagged test rather than a moved one, so it is out of scope.

Verification

mise run lint 0 issues, mise run test:ci fully green, GOOS=windows go vet ./... clean.

🤖 Generated with Claude Code

---

Note

Low Risk
Only test layout and environment isolation; no runtime version-check or auto-update logic changes.

Overview
Test-only hardening for versioncheck: no production behavior changes.

Adds shared isolateMiseInstallEnv (clears MISE_INSTALLS_DIR / MISE_DATA_DIR) so host mise roots cannot make “unknown path → curl install” cases look like mise upgrade. The Unix UpdateCommandForCurrentBinary table calls it in each subtest; isolateWindowsInstallEnv now delegates to the same helper instead of duplicating those Setenv calls.

Moves three CheckAndNotify tests that depend on interactive auto-update (skip-until-next-version caching and installer-failure retry hint) into versioncheck_unix_test.go under the unix build tag, because on Windows installerAutoRuns is false and maybeAutoUpdate bails out before those paths run. brewUpgradeCmd moves with them; shared versioncheck_test.go drops the duplicated tests and unused imports.

^{Reviewed by Cursor Bugbot for commit dfef5ab. Configure here.}

[Copilot]

🟢 Approval recommended

Changes are test-only, scoped, and align build tags/env isolation with the intended platform-specific behaviors.

Pull request overview

This PR improves versioncheck test hygiene by (1) isolating mise-related environment variables across platforms so host mise roots don’t affect update-command detection tests, and (2) correctly scoping unix-only auto-update tests behind the unix build tag to avoid Windows-only behavior differences.

Changes:

• Adds a shared isolateMiseInstallEnv test helper to clear MISE_INSTALLS_DIR / MISE_DATA_DIR, and uses it from both unix and Windows tests.
• Updates the unix UpdateCommandForCurrentBinary table test to call isolateMiseInstallEnv per subtest, preventing host environment leakage.
• Moves three CheckAndNotify tests that rely on unix auto-update behavior into versioncheck_unix_test.go (//go:build unix) and removes them from the untagged test file.

File summaries

File	Description
cmd/entire/cli/versioncheck/versioncheck_windows_test.go	Reuses shared mise env isolation from Windows-specific install env helper.
cmd/entire/cli/versioncheck/versioncheck_unix_test.go	Adds per-subtest mise env isolation and relocates unix-only CheckAndNotify test coverage under the unix build tag.
cmd/entire/cli/versioncheck/versioncheck_test.go	Removes unix-only tests/constants from the untagged cross-platform test file.
cmd/entire/cli/versioncheck/fixture_test.go	Introduces shared isolateMiseInstallEnv helper for cross-platform test env isolation.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.