fix(strategy): prevent shadow cleanup with malformed session state - #2358
Open
ChetanReddyC wants to merge 4 commits into
Open
fix(strategy): prevent shadow cleanup with malformed session state#2358ChetanReddyC wants to merge 4 commits into
ChetanReddyC wants to merge 4 commits into
Conversation
Entire-Checkpoint: 01M25WJK5B7ZK573P7N42V6B1T
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StateStore.Listtolerant for observational callersStateStore.ListStrictfor operations requiring a complete inventoryWhen persisted session state is malformed, cleanup now aborts instead of potentially deleting a still-needed shadow ref.
Closes #2350
Testing
go test ./cmd/entire/cli/session -run 'TestStateStore_List_(SkipsMalformedState|Strict_RejectsMalformedState)$' -count=1go test ./cmd/entire/cli/strategy -run 'Test(CleanupPushedShadowBranches_MalformedStateFailsClosed|DeleteShadowBranchesIfUnchanged_MalformedStatePreservesBranch)$' -count=1go vet ./cmd/entire/cli/session ./cmd/entire/cli/strategyFull Windows package runs still encounter existing temporary-directory lock failures reproduced unchanged on
origin/main.