Share benign-race classifier; match landed code-only form#591
Merged
Conversation
anderdc
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log-hygiene sweep of the benign-race handling around permissionless cranks. No behavior change to flow control; one log-level fix.
benign_markerinsolana/client.pyreplaces five copies of theany(m in str(e))predicate (swap loop x3, weights vote, CLI crank). Returns the matched error NAME.{'Custom': N}with no name. CLI already matched both forms; the validator matched names only, so a landed benign race logged a false-alarm ERROR. All sites now match both via a single name->code map.no-op (PoolNotClosed)) instead of the full ~1KB RPC simulation blob.resolve_pool no-op (peer won the race)dropped -PoolNotClosed/SeedSlotNotYetProducedmean the validator was early, not that a peer won.Tests: classifier test covers name form, landed code-only form, and non-benign passthrough. Full suite passes (795).