fix(scoring): unique_repos_contributed_to undercounts when mirror fil…#1625
Open
lourincedaging0-commits wants to merge 2 commits into
Conversation
…e-fetch is pending/fails score_pr() only added a MERGED PR's repo to unique_repos_contributed_to at the very end of the function, after three earlier return paths that fire whenever the mirror's file-diff data isn't available yet (scoring_data_stored=False, a MirrorRequestError, or an empty files result). Since a merged PR is already counted toward total_merged_prs independent of file-fetch status, this let repo attribution silently depend on this round's file-fetch timing instead of the PR itself. Move the attribution earlier, right after the repo_config lookup, so a pending/failed mirror fetch no longer drops the PR's repo from unique_repos_contributed_to. Fixes entrius#1616
…buted-to-mirror-fetch-1616
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e-fetch is pending/fails
score_pr() only added a MERGED PR's repo to unique_repos_contributed_to at the very end of the function, after three earlier return paths that fire whenever the mirror's file-diff data isn't available yet (scoring_data_stored=False, a MirrorRequestError, or an empty files result). Since a merged PR is already counted toward total_merged_prs independent of file-fetch status, this let repo attribution silently depend on this round's file-fetch timing instead of the PR itself.
Move the attribution earlier, right after the repo_config lookup, so a pending/failed mirror fetch no longer drops the PR's repo from unique_repos_contributed_to.
Fixes #1616