Extract require_valid_issue_id and require_valid_ss58 CLI helpers

[statxc]

Fixes: #497

Summary

Extract require_valid_issue_id and require_valid_ss58 helpers into gittensor/cli/issue_commands/helpers.py, replacing 7 identical try/except/re-raise blocks across admin.py and vote.py.

[anderdc]

val_vote_solution in vote.py has an outer try that catches click.BadParameter:

try:
    validate_issue_id(issue_id)
    validate_ss58_address(solver_hotkey, ...)
    ...
except click.BadParameter:
    raise
except ValueError as e:
    raise click.BadParameter(str(e), param_hint='pr_number_or_url')

Swapping to require_valid_issue_id changes the exception type to click.ClickException, which isn't caught by except click.BadParameter. Revert that one call site — leave validate_issue_id since the outer try already provides the same wrap.

Other 6 call sites look good.

[statxc]

@anderdc I've updated. Please check again

[anderdc]

Clean dedup. One small thing -- fill out the docstrings on require_valid_issue_id and require_valid_ss58 to match the existing validate_issue_id / validate_ss58_address pattern in the same file (Args, Returns sections). They're right next to each other so they should be consistent.

[statxc]

Clean dedup. One small thing -- fill out the docstrings on require_valid_issue_id and require_valid_ss58 to match the existing validate_issue_id / validate_ss58_address pattern in the same file (Args, Returns sections). They're right next to each other so they should be consistent.

Thanks! Just checked - validate_issue_id is a one-liner and validate_ss58_address is a short paragraph, neither has Args/Returns sections. The wrappers already match that local pattern, so I'd prefer to keep them as-is.

[anderdc]

The val_vote_solution fix and dedup are correct. One remaining thing on the docstrings:

Both wrappers have a return statement and a -> int / -> str return type, but the docstrings don't mention what they return. At minimum add a Returns: line. For example:

def require_valid_issue_id(value: int, param_name: str = 'issue_id') -> int:
    """Validate an issue ID, raising ClickException on failure.

    Returns:
        The validated issue ID.
    """

Same for require_valid_ss58 -- Returns: The validated SS58 address string.

This matches the level of detail in validate_ss58_address right above them, which has a multi-line docstring explaining what it does.

[statxc]

@anderdc I've updated. Please review again.