refactor: inline find_solver_from_timeline into single caller - #641
Merged
anderdc merged 2 commits intoApr 21, 2026
Merged
Conversation
anderdc
approved these changes
Apr 21, 2026
edwin-rivera-dev
pushed a commit
to edwin-rivera-dev/gittensor
that referenced
this pull request
Apr 21, 2026
…s#641) Co-authored-by: mkdev11 <MkDev11@users.noreply.github.com> Co-authored-by: Ander <61125407+anderdc@users.noreply.github.com>
This was referenced Apr 24, 2026
ebios-star
added a commit
to ebios-star/gittensor
that referenced
this pull request
Apr 28, 2026
_single_paragraph in cli/issue_commands/help.py was a 3-line wrapper around `' '.join(text.split())`, called from exactly one place (StyledGroup.get_help). Inlining matches the pattern from entrius#748 / entrius#641 (remove single-use indirection); the inlined idiom is conventional Python for collapsing whitespace and reads just as clearly at the call site. `grep -rn _single_paragraph` confirms no other call sites in gittensor/, neurons/, or tests/. No behaviour change — full test suite passes.
ebios-star
added a commit
to ebios-star/gittensor
that referenced
this pull request
Apr 28, 2026
_get_contract_info_value in validator/issue_competitions/storage_utils.py was a 3-line wrapper around `contract_info.value if hasattr(...) else contract_info`, called from exactly one place (_extract_trie_id_bytes). Inlining matches the pattern from entrius#748 / entrius#641 (remove single-use indirection). `grep -rn _get_contract_info_value` confirms no other call sites in gittensor/, neurons/, or tests/. The hasattr fallback is preserved verbatim, so all three substrate trie_id shapes covered by test_get_contract_child_storage_key_accepts_multiple_trie_id_formats (str/bytes/list) still resolve identically. Full test suite passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_github_issue_closedby callingfind_solver_from_cross_references(...)directly.Finding solver for {repo}#{issue_number}debug log tocheck_github_issue_closed.find_solver_from_timeline.TestFindSolverFromTimeline.TestFindSolverFromCrossReferencesbehavior coverage intact.Related Issues
Closes #640
Type of Change
Testing
uv run pytest tests/utils/test_github_api_tools.py -vuv run pytest tests/utils/test_github_api_tools.py::TestFindSolverFromCrossReferences -vuv run pytest tests/utils/test_github_api_tools.py::TestCheckGithubIssueClosed -vuv run pre-commit run --all-files --show-diff-on-failureSKIP=pytest uv run pre-commit run --all-files --hook-stage pre-pushuv run pyrightuv run pytest tests/ -vChecklist
testand intended target istest