refactor: drop unused netuid parameter from get_miner_coldkey

[ebios-star]

Summary

Closes #862.

`get_miner_coldkey` in gittensor/validator/utils/issue_competitions.py:11 declared a `netuid: int` parameter but never referenced it inside the body — only `subtensor.get_hotkey_owner(hotkey)` is called, which is netuid-agnostic in bittensor.

The single caller in validator/issue_competitions/forward.py:139 dutifully threaded its own `self.config.netuid` through, and paid a `# type: ignore[attr-defined]` for the bittensor config attribute access. Both the parameter and the type-ignore comment only existed to feed an unused argument.

After this change:

• `get_miner_coldkey(hotkey, subtensor)` is the new signature.
• The lone call site drops both the third argument and the `# type: ignore[attr-defined]` comment.

`grep -rn get_miner_coldkey` confirms exactly one caller across `gittensor/`, `neurons/`, and `tests/`.

Net: -2 / +0 lines on the source side, plus a fresh `tests/validator/utils/test_issue_competitions.py` that pins the new signature.

Related Issues

Closes #862.

Type of Change

• Bug fix
• New feature
• Refactor
• Documentation
• Other

Testing

New `tests/validator/utils/test_issue_competitions.py` covers four cases:

• success path → owner string returned, `subtensor.get_hotkey_owner` called with the hotkey.
• falsy owner → returns `None`.
• subtensor exception → returns `None`.
• regression guard ensuring `netuid=` is no longer accepted (`TypeError`).

`uv run --extra dev pytest tests/` — all 686 tests pass (682 baseline + 4 new).

Checklist

• Code follows project style guidelines
• Self-review completed
• Changes are documented (if applicable)

[ebios-star]

Hi @anderdc @LandynDev — friendly review request whenever you have a moment.

This PR closes #862. get_miner_coldkey declared a netuid: int parameter that's never referenced in its body, and the lone call site in validator/issue_competitions/forward.py was paying a # type: ignore[attr-defined] to thread self.config.netuid through. Dropping the parameter eliminates both — the call site stops needing the type-ignore comment as a side benefit.

Tests: 4 new cases in tests/validator/utils/test_issue_competitions.py (the file had none) — success path, falsy-owner, subtensor-exception, and a guard that the dead parameter cannot reappear. Full suite (686) passes.

Happy to address any feedback or rebase if needed.

[anderdc]

Remove tests.

[ebios-star]

Done @anderdc — thanks for the review.

Removed the test file. The PR is now just the 2-line source change:

- def get_miner_coldkey(hotkey: str, subtensor: bt.Subtensor, netuid: int) -> Optional[str]:
+ def get_miner_coldkey(hotkey: str, subtensor: bt.Subtensor) -> Optional[str]:

- miner_coldkey = get_miner_coldkey(miner_hotkey, self.subtensor, self.config.netuid)  # type: ignore[attr-defined]
+ miner_coldkey = get_miner_coldkey(miner_hotkey, self.subtensor)

Branch rebased onto current test and force-pushed (--force-with-lease).