fix(config): use bittensor logging for neuron full path in check_config - #935
Merged
anderdc merged 1 commit intoMay 8, 2026
Merged
Conversation
Contributor
Author
|
Hi, just checking if there is anything I should adjust here. The branch is behind test now, but GitHub shows it can still be merged cleanly. I can rebase if preferred. |
anderdc
requested changes
May 6, 2026
anderdc
left a comment
Collaborator
There was a problem hiding this comment.
Drop all the tests, make this just the one-liner to move from print to bt.logging.
kyan9400
force-pushed
the
fix/replace-check-config-print-with-logging
branch
from
May 6, 2026 22:30
cf12e8e to
ad08249
Compare
anderdc
requested changes
May 7, 2026
anderdc
left a comment
Collaborator
There was a problem hiding this comment.
Drop all the tests, make this just the one-liner to move from print to bt.logging.
Co-authored-by: Cursor <cursoragent@cursor.com>
kyan9400
force-pushed
the
fix/replace-check-config-print-with-logging
branch
from
May 7, 2026 23:25
ad08249 to
3b3c90e
Compare
anderdc
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
check_configprinted the resolved neuron directory withprint, which bypassesbt.loggingand can pollute stdout for validator/miner processes.Change
This PR replaces the raw
printcall withbt.logging.debug, using a clearNeuron full path:message while preserving the existing path setup behavior.Tests
Added focused tests covering:
check_configno longer emits the legacyfull path:message to stdout/stderr.config.neuron.full_pathis set correctly.Testing