refactor: remove unused REPO_SCAN_* constants - #943
Closed
ebios-star wants to merge 1 commit into
Closed
Conversation
These three constants were only referenced by gittensor/validator/issue_discovery/repo_scan.py, which was deleted in entrius#796 when issue discovery was routed through das-github-mirror. Verified zero remaining callers across the codebase.
Contributor
Author
8 tasks
Collaborator
|
Closing — please consolidate into #917. |
8 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three constants in
gittensor/constants.pyare unreferenced anywhere in the codebase:REPO_SCAN_PER_REPO_CAPREPO_SCAN_GLOBAL_CAPREPO_SCAN_CONCURRENCYThey were only used by
gittensor/validator/issue_discovery/repo_scan.py, which was deleted in #796 when issue discovery moved todas-github-mirror. The constants were left orphaned.Verified zero remaining references via
grep -rni "REPO_SCAN" ..Test suite: 726 passed.