refactor: deduplicate calculate_final_earned_score between PullRequest and ScoredMirrorPR - #951
Merged
anderdc merged 1 commit intoMay 6, 2026
Conversation
dataCenter430
force-pushed
the
refactor/dedupe-scoring-and-weights-loader
branch
2 times, most recently
from
May 4, 2026 16:40
88a91f0 to
2fc83d3
Compare
dataCenter430
force-pushed
the
refactor/dedupe-scoring-and-weights-loader
branch
8 times, most recently
from
May 6, 2026 21:12
d969ec9 to
6e2f951
Compare
…t and ScoredMirrorPR
dataCenter430
force-pushed
the
refactor/dedupe-scoring-and-weights-loader
branch
from
May 6, 2026 21:55
6e2f951 to
b41013a
Compare
anderdc
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #950
Extract
_apply_score_multipliers(base_score, multipliers, pr_label)intoclasses.pysoPullRequestandScoredMirrorPRshare one implementation of the multiplier computation and log lines.Changes
_apply_score_multipliersas a module-level function inclasses.pyPullRequest.calculate_final_earned_scoreto delegate to itScoredMirrorPR.calculate_final_earned_scoreto import and delegate to itfrom math import prodandimport bittensor as btfromscored_pr.pyBehaviour
No behaviour change — multiplier keys, order, earned-score assignment, and log output are identical to before.
Test plan