refactor: remove unused GITHUB_DOMAIN constant - #954
Closed
ebios-star wants to merge 1 commit into
Closed
Conversation
GITHUB_DOMAIN is defined at module scope in gittensor/classes.py but has zero references anywhere in gittensor/, neurons/, or tests/. The sites that build GitHub URLs use inline f-strings (e.g. f'https://github.com/{repo}/issues/{issue_number}') and don't import this constant. Verified via 'grep -rn GITHUB_DOMAIN' — only the definition line.
Contributor
Author
|
@anderdc whenever you have a moment, this is a one-line removal of an unused module-level constant. Happy to revise scope if you'd prefer. Thanks! |
8 tasks
Collaborator
|
Closing — please consolidate into #917. |
8 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_DOMAIN = 'https://github.com/'is defined at module scope in gittensor/classes.py but has zero references anywhere ingittensor/,neurons/, ortests/. The sites that build GitHub URLs use inline f-strings (e.g.f'https://github.com/{repo}/issues/{issue_number}'incli/issue_commands/helpers.py,mutations.py, andsubmissions.py) and don't import this constant.Verified via
grep -rn GITHUB_DOMAIN— only the definition line.Net: -2 lines.
Type of Change
Testing
pytest tests/— all 726 tests pass.Checklist