[4.36.0] hw 1.9.54 develop-hw PR by Tnks2U · Pull Request #2754 · entrylabs/entryjs

Tnks2U · 2024-05-23T08:43:31Z

https://oss.navercorp.com/entry/entry2/issues/8320

일부 블럭의 파라미터 변경 교차로 도달 판단 블럭 추가

PR_HexaBoard 버그 수정

Feature/hardware lite

AsomeKit 확장 모듈 블록 추가

[네오피아] 버그수정

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

github-actions · 2024-05-23T08:44:36Z

@@ -0,0 +1,6719 @@
+'use strict';
+
+(function() {


🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

Suggested change

(function() {

(function () {

github-actions · 2024-05-23T08:44:36Z

+            this.HUSKY = {
+                CENT_X: 160,
+                CENT_Y: 120,
+                getDist: function(x, y) {


⚠️ [eslint] <object-shorthand> _{reported by reviewdog 🐶}
Expected method shorthand.

Suggested change

getDist: function(x, y) {

getDist(x, y) {

github-actions · 2024-05-23T08:44:36Z

+            this.HUSKY = {
+                CENT_X: 160,
+                CENT_Y: 120,
+                getDist: function(x, y) {


🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

Suggested change

getDist: function(x, y) {

getDist: function (x, y) {

github-actions · 2024-05-23T08:44:36Z

+                        return;
+                    }
+                    case this.receiveType.INT: {
+                        let _sign = readData[2] === 1;


⚠️ [eslint] <prefer-const> _{reported by reviewdog 🐶}
'_sign' is never reassigned. Use 'const' instead.

Suggested change

let _sign = readData[2] === 1;

const _sign = readData[2] === 1;

github-actions · 2024-05-23T08:44:36Z

+                        return;
+                    }
+                    case this.receiveType.FLOAT: {
+                        let _sign = readData[2] & 0x80; // -: 1, +:0


⚠️ [eslint] <prefer-const> _{reported by reviewdog 🐶}
'_sign' is never reassigned. Use 'const' instead.

Suggested change

let _sign = readData[2] & 0x80; // -: 1, +:0

const _sign = readData[2] & 0x80; // -: 1, +:0

github-actions · 2024-05-23T08:44:38Z

+            let _promise = new Promise((resolve) => {
+                timeout = timeout ?? 1000;
+                Entry.CodeWizLite.intervalId = setInterval(() => {
+                    // console.log(Entry.CodeWizLite.intervalId, 'runOK:', Entry.CodeWizLite.sensorData[id]);


⚠️ [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 109. Maximum allowed is 100.

github-actions · 2024-05-23T08:44:38Z

+                timeout = timeout ?? 1000;
+                Entry.CodeWizLite.intervalId = setInterval(() => {
+                    // console.log(Entry.CodeWizLite.intervalId, 'runOK:', Entry.CodeWizLite.sensorData[id]);
+                    let ret = Entry.CodeWizLite.sensorData[id]?.value;


⚠️ [eslint] <prefer-const> _{reported by reviewdog 🐶}
'ret' is never reassigned. Use 'const' instead.

Suggested change

let ret = Entry.CodeWizLite.sensorData[id]?.value;

const ret = Entry.CodeWizLite.sensorData[id]?.value;

github-actions · 2024-05-23T08:44:38Z

+                        ▼을 눌러 SCON에 연결된 네오픽셀의 개수와 사용을 설정할 수 있습니다.`,
+                        CodeWizLite_neopixel_brightness: `밝기를 0~255 사이 값으로 지정합니다.`,
+                        CodeWizLite_neopixel_setColor_one: `입력한 번호의 LED를 선택한 색으로 켭니다.`,
+                        CodeWizLite_neopixel_setColor_one2: `입력한 번호의 LED를 빨강, 초록, 파랑에 입력된 값의 색으로 켭니다.


⚠️ [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 101. Maximum allowed is 100.

github-actions · 2024-05-23T08:44:38Z

+                        왼쪽색부터 오른쪽색까지 HSL색표현의 그라데이션으로 채워집니다.
+                        범위는 초기화한 LED범위를 벗어날 수 없으며 서로 다른 값이여야 합니다.
+                        LED 번호가 작은 값은 왼쪽에 큰 값은 오른쪽에 위치해야합니다.`,
+                        CodeWizLite_neopixel_wheeeeeeel: `녹색, 빨강, 파랑의 세 가지색을 기준으로 섞은 색을 순환시켜 켜주는 블록입니다.


⚠️ [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 103. Maximum allowed is 100.

github-actions · 2024-05-23T08:44:38Z

+                        CodeWizLite_OLED_isCollision: `OLED에 출력된 내용의 줄바꿈을 설정합니다.`,
+                        CodeWizLite_OLED_specialChar: `OLED에 기호를 출력합니다.`,
+                        CodeWizLite_OLED_setFont: `글꼴과 글자 크기를 ▼ 을 눌러 설정합니다.`,
+                        CodeWizLite_OLED_startScroll: `OLED에 입력된 내용을 지정한 화살표방향으로 이동시킵니다. 시작과 종료는 y좌표를 0~7 페이지로 나눈 것으로 각 페이지는 다음과 같은 y 좌표를 가집니다.


⚠️ [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 143. Maximum allowed is 100.

kkongnamul11 and others added 12 commits December 26, 2023 15:57

develop-hw로 재 PR

f52728f

Merge commit '8e634e25458e23efdc0ce1a00468cdf104fd1794' into develop-hw

600e1af

버그 수정(OLED, Blynk), 초기화 부분 추가

4d50a52

feature/오즈아이 블록 추가

b6964aa

feature/브라우저로 연결하기 기능 추가

5f975b4

컬러 데이터 비교시 버그 수정

fb4db05

일부 블럭의 파라미터 변경 교차로 도달 판단 블럭 추가

AsomeKit 확장 모듈 블록 추가

683727c

Merge branch 'entrylabs:develop-hw' into develop-hw

0fc29bd

Merge pull request #2689 from makeitnow-company/develop-hw

4f28f25

PR_HexaBoard 버그 수정

Merge pull request #2698 from neocodable/feature/hardwareLite

0a30405

Feature/hardware lite

Merge pull request #2724 from CHOGyungChan/develop-hw

0128c77

AsomeKit 확장 모듈 블록 추가

Merge pull request #2709 from SketchwareMoon/develop-hw

fcff344

[네오피아] 버그수정

Tnks2U requested review from kimorkim, lizwan and prisml May 23, 2024 08:43

Tnks2U self-assigned this May 23, 2024

github-actions Bot reviewed May 23, 2024

View reviewed changes

kimorkim approved these changes May 27, 2024

View reviewed changes

Tnks2U merged commit 846e77e into develop May 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.36.0] hw 1.9.54 develop-hw PR#2754

[4.36.0] hw 1.9.54 develop-hw PR#2754
Tnks2U merged 12 commits intodevelopfrom
develop-hw

Tnks2U commented May 23, 2024

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

github-actions Bot May 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	let _sign = readData[2] === 1;
	const _sign = readData[2] === 1;

	let _sign = readData[2] & 0x80; // -: 1, +:0
	const _sign = readData[2] & 0x80; // -: 1, +:0

	let ret = Entry.CodeWizLite.sensorData[id]?.value;
	const ret = Entry.CodeWizLite.sensorData[id]?.value;

Conversation

Tnks2U commented May 23, 2024

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 23, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants