Update Config.rb to raise error on badly formatted yaml#243
Merged
Conversation
patrobinson
approved these changes
Jun 15, 2018
| base_dir = File.dirname(File.expand_path(resolved_config_file)) | ||
| new(config, base_dir) | ||
| rescue Psych::SyntaxError => error | ||
| raise ConfigParseError, "Unable to parse stack_master.yml: #{error}" |
Contributor
There was a problem hiding this comment.
I'd love it if we could create our own wrapper for yaml parser and catch this, it's a pain in parameter files and templates too
viraptor
reviewed
Jun 15, 2018
| base_dir = File.dirname(File.expand_path(resolved_config_file)) | ||
| new(config, base_dir) | ||
| rescue Psych::SyntaxError => error | ||
| raise ConfigParseError, "Unable to parse stack_master.yml: #{error}" |
Contributor
There was a problem hiding this comment.
stack_master.yml is hardcoded in the message. Should it be #{config_file} instead?
Contributor
Author
There was a problem hiding this comment.
Yes, it should be stack_master.yml anyways, but using the resolved_config_file would probably help more too. See d62f9ba
peoram
approved these changes
Jun 15, 2018
viraptor
approved these changes
Jun 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With badly formatted yaml I get this error message, which usually takes some time for me to remember what the problem is.
Now, this helps me remember in a 🔦 :