Skip to content

Update Config.rb to raise error on badly formatted yaml #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denmat merged 2 commits into from
Jun 15, 2018
Merged

Update Config.rb to raise error on badly formatted yaml #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f9cf9d
Update Config.rb to raise error on badly formatted yaml
Jun 15, 2018
d62f9ba
Return resovled config file in error message
Jun 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/stack_master/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@

module StackMaster
class Config
ConfigParseError = Class.new(StandardError)

def self.load!(config_file = 'stack_master.yml')
resolved_config_file = search_up_and_chdir(config_file)
config = YAML.load(File.read(resolved_config_file))
base_dir = File.dirname(File.expand_path(resolved_config_file))
new(config, base_dir)
rescue Psych::SyntaxError => error
raise ConfigParseError, "Unable to parse #{resolved_config_file}: #{error}"
end

attr_accessor :stacks,
Expand Down
12 changes: 12 additions & 0 deletions spec/stack_master/config_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,24 @@
additional_parameter_lookup_dirs: ['production']
)
}
let(:bad_yaml) { "a: b\n- c" }

describe ".load!" do
it "fails to load the config if no stack_master.yml in parent directories" do
expect { StackMaster::Config.load!('stack_master.yml') }.to raise_error Errno::ENOENT
end

it "raises exception on invalid yaml" do
begin
orig_dir = Dir.pwd
Dir.chdir './spec/fixtures/'
allow(File).to receive(:read).and_return(bad_yaml)
expect { StackMaster::Config.load!('stack_master.yml') }.to raise_error StackMaster::Config::ConfigParseError
ensure
Dir.chdir orig_dir
end
end

it "searches up the tree for stack master yaml" do
begin
orig_dir = Dir.pwd
Expand Down