Conversation
orien
commented
Mar 12, 2020
| StackMaster::Commands::Delete.perform(region, stack_name) | ||
| StackMaster::Commands::Delete.perform(region, stack_name).success? | ||
| end | ||
| @kernel.exit false unless success |
Member
Author
There was a problem hiding this comment.
stack_master delete is updated to exit with status 1 if the command object is not successful, or a disallowed AWS account is used.
orien
commented
Mar 12, 2020
| """ | ||
| Account '33333333' is not an allowed account. Allowed accounts are ["11111111"]. | ||
| """ | ||
| And the exit status should be 1 |
Member
Author
There was a problem hiding this comment.
Add a feature, specifying the behaviour of the delete command when using a disallowed AWS account.
orien
commented
Mar 12, 2020
|
|
||
| def stack_resources | ||
| @stack_resources = cf.describe_stack_resources(stack_name: @stack_definition.stack_name).stack_resources | ||
| @stack_resources ||= cf.describe_stack_resources(stack_name: @stack_definition.stack_name).stack_resources |
Member
Author
There was a problem hiding this comment.
Memoising this results in less API calls.
orien
force-pushed
the
stack-not-found
branch
2 times, most recently
from
6745238 to
3e8c7cf
Compare
patrobinson
approved these changes
Mar 13, 2020
Member
Author
|
☝️ Just rebased against master to resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #235 (comment), StackMaster aborts, but with exit status
0upon not finding the specified stack in AWS. It is expected to report an error via a non-zero exit status.Update the
delete,outputs, andresourcescommands to exit with a status of1if the specified stack does not exist in AWS.Also the
deletecommand now exits with status1if using a disallowed AWS account.