Change itemsTarget from float to int for query budgeting

[DZakh]

Summary

Refactors the query budget system to use integers instead of floats for itemsTarget, improving precision and simplifying budget calculations throughout the fetch state management.

Key Changes

• Type change: itemsTarget field in query and pendingQuery types changed from float to int
• Budget calculation: densityItemsTarget function now:
  • Takes density as a parameter instead of deriving it from partition state
  • Returns int instead of float
  • Applies Math.ceil to density-based calculations and enforces a minimum of 1
• Density extraction: New getTrustedDensity helper function extracts density calculation logic, requiring two responses before trusting the estimate
• Gap filling: pushGapFillQueries refactored to:
  • Accept partitionBudget parameter for calculating "available density" when no trusted density exists
  • Use trusted density for chunked queries (only when density > 0)
  • Fall back to available density for open-ended probes
• Water-fill algorithm: Updated to:
  • Calculate probeItemsTarget once per round as an even split of fresh budget
  • Only chunk when trusted positive density exists
  • Apply ceiling and minimum-1 logic to all density-based itemsTarget calculations
• Budget tracking: All budget accumulation now converts int itemsTarget to float at the point of use
• SourceManager: Simplified query execution to pass itemsTarget directly without ceiling/validation logic (now handled upstream)
• Tests: Updated all test fixtures to use integer literals for itemsTarget

Notable Implementation Details

• Minimum itemsTarget is now 1 (enforced via Pervasives.max(1, ...)) rather than a named constant, ensuring queries never ask the backend for 0 items
• Density is only trusted after two responses; single-sample estimates are treated as unknown density
• Chunking only occurs with positive trusted density; zero-density partitions use open-ended probes instead
• Available density for gap fills is calculated as partitionBudget / remainingRange, spreading the budget proportionally over remaining work

https://claude.ai/code/session_01McpcXkR3pPWfEcq4mCj9Sw

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bca3d759-fb97-411a-a9e6-708f27589961

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}