Increase cross-chain alignment margin from 5% to 10% - #1447
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012c95hdFAGTHj1b7aT6tZ64
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe cross-chain alignment clamp increases its non-anchor progress margin from 5% to 10%. Related test expectations, comments, and waiting messages are updated for the resulting block thresholds and fetch estimates. ChangesCross-chain alignment
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increases the progress margin used for cross-chain state alignment from 5% to 10% to reduce flapping behavior when chains track the anchor closely.
Changes
CrossChainState.resto use 10% margin instead of 5% when calculating the maximum target block for non-anchor chainsCrossChainState_test.resto reflect the new margin:Implementation Details
The margin is applied when a chain has an anchor for alignment. The increased margin prevents chains whose progress closely tracks the anchor from repeatedly entering and exiting the clamp on small frontier movements, which was causing unnecessary pipeline stalls on alternating ticks.
https://claude.ai/code/session_012c95hdFAGTHj1b7aT6tZ64
Summary by CodeRabbit
Bug Fixes
Tests