deps: Bump protobuf and grpc#42435
Conversation
Signed-off-by: Jonh Wendell <jwendell@redhat.com>
jwendell
requested review from
RyanTheOptimist,
abeyad,
adisuissa,
danzh2010,
ggreenway,
kyessenov,
mattklein123 and
wbpcode
as code owners
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
There was a problem hiding this comment.
Do you know the cause of failure? I want to make sure we are not breaking this filter.
@sumitkmr2 @pranavrautgoogle can you help diagnosing the test failure with the new protobuf, please?
There was a problem hiding this comment.
It's failing here: https://github.com/envoyproxy/envoy/blob/main/test/extensions/filters/http/grpc_field_extraction/message_converter/message_converter_test_lib.h#L36
I was hoping that @sumitkmr2 (the author of that test) could help on this.
There was a problem hiding this comment.
I've pushed a fix to this test and removed the FIXME.
There was a problem hiding this comment.
Apologies, I was on leave. The fix looks good to me, thanks @jwendell for the fix!
| } | ||
|
|
||
| - if (in_->BytesAvailable() < static_cast<pb::int64>(current_message_size_)) { | ||
| + if (in_->BytesAvailable() < static_cast<int64_t>(current_message_size_)) { |
There was a problem hiding this comment.
Yes, I can go ahead and make this PR upstream today
|
/wait-any |
Protobuf 33.1 changed DebugString() to produce unparseable output (random prefixes, whitespace) for security reasons. The test was using DebugString() to serialize a matcher proto then parsing it with TextFormat::ParseFromString(), which now fails silently. Replace DebugString() with TextFormat::PrintToString() which produces proper text proto format. Signed-off-by: Jonh Wendell <jwendell@redhat.com>
|
ping @envoyproxy/envoy-maintainers |
|
@yanavlasov i think this waiting for further review |
agrawroh
left a comment
agrawroh
left a comment
There was a problem hiding this comment.
It looks good to me. I'm okay taking a patch in grpc_httpjson_transcoding until it gets upstreamed (we can have a tracking ticket).
Will let @yanavlasov give a final approval.
repokitteh-read-only
bot
removed
the
deps
Signed-off-by: Jonh Wendell <jwendell@redhat.com> Signed-off-by: dinesh-murugiah <dinesh.murugiah@freshworks.com>
6 participants
No description provided.