Skip to content

dym: fix a bug where part of body maynot be sent to upstream#44081

Merged
wbpcode merged 2 commits intoenvoyproxy:mainfrom
wbpcode:dev-fix-body-read-dym
Mar 23, 2026
Merged

dym: fix a bug where part of body maynot be sent to upstream#44081
wbpcode merged 2 commits intoenvoyproxy:mainfrom
wbpcode:dev-fix-body-read-dym

Conversation

@wbpcode
Copy link
Copy Markdown
Member

@wbpcode wbpcode commented Mar 23, 2026

Commit Message: dym: fix a bug where part of body maynot be sent to upstream
Additional Description:

I have provided two different ABIs (buffered body and received body) to access buffered or latest received body. The the previous legacy addDecodedData and addEncodedData have been unnecessary.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close #43063

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
@wbpcode
Copy link
Copy Markdown
Member Author

wbpcode commented Mar 23, 2026

This also need to be back ported to 1.36/1.37

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Copy link
Copy Markdown
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the fix!

@wbpcode wbpcode merged commit 6628e6b into envoyproxy:main Mar 23, 2026
29 checks passed
@wbpcode wbpcode deleted the dev-fix-body-read-dym branch March 23, 2026 10:28
wbpcode added a commit to wbpcode/envoy that referenced this pull request Mar 23, 2026
…oxy#44081)

Commit Message: dym: fix a bug where part of body maynot be sent to
upstream
Additional Description:

I have provided two different ABIs (buffered body and received body) to
access buffered or latest received body. The the previous legacy
addDecodedData and addEncodedData have been unnecessary.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close
envoyproxy#43063

---------

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode added a commit to wbpcode/envoy that referenced this pull request Mar 23, 2026
…oxy#44081)

Commit Message: dym: fix a bug where part of body maynot be sent to
upstream
Additional Description:

I have provided two different ABIs (buffered body and received body) to
access buffered or latest received body. The the previous legacy
addDecodedData and addEncodedData have been unnecessary.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close
envoyproxy#43063

---------

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
agrawroh pushed a commit that referenced this pull request Mar 24, 2026
#44081) (#44084)

Commit Message: dym: fix a bug where part of body maynot be sent to
upstream
Additional Description:

I have provided two different ABIs (buffered body and received body) to
access buffered or latest received body. The the previous legacy
addDecodedData and addEncodedData have been unnecessary.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close
#43063

---------

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
agrawroh pushed a commit that referenced this pull request Mar 24, 2026
#44081) (#44083)

Commit Message: dym: fix a bug where part of body maynot be sent to
upstream
Additional Description:

I have provided two different ABIs (buffered body and received body) to
access buffered or latest received body. The the previous legacy
addDecodedData and addEncodedData have been unnecessary.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close
#43063

---------

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
fishcakez pushed a commit to fishcakez/envoy that referenced this pull request Mar 25, 2026
…oxy#44081)

Commit Message: dym: fix a bug where part of body maynot be sent to
upstream
Additional Description:

I have provided two different ABIs (buffered body and received body) to
access buffered or latest received body. The the previous legacy
addDecodedData and addEncodedData have been unnecessary.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close
envoyproxy#43063

---------

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Apr 1, 2026
…oxy#44081)

Commit Message: dym: fix a bug where part of body maynot be sent to
upstream
Additional Description:

I have provided two different ABIs (buffered body and received body) to
access buffered or latest received body. The the previous legacy
addDecodedData and addEncodedData have been unnecessary.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close
envoyproxy#43063

---------

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
nshipilov pushed a commit to nshipilov/envoy that referenced this pull request Apr 13, 2026
…oxy#44081)

Commit Message: dym: fix a bug where part of body maynot be sent to
upstream
Additional Description:

I have provided two different ABIs (buffered body and received body) to
access buffered or latest received body. The the previous legacy
addDecodedData and addEncodedData have been unnecessary.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close
envoyproxy#43063

---------

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
krinkinmu pushed a commit to grnmeira/envoy that referenced this pull request Apr 20, 2026
…oxy#44081)

Commit Message: dym: fix a bug where part of body maynot be sent to
upstream
Additional Description:

I have provided two different ABIs (buffered body and received body) to
access buffered or latest received body. The the previous legacy
addDecodedData and addEncodedData have been unnecessary.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close
envoyproxy#43063

---------

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExtAuthz + Dynamic Module http2 request blocked until timeout

3 participants