[bp/1.37] dym: fix a bug where part of body maynot be sent to upstream (#44081)#44083
Merged
agrawroh merged 2 commits intoenvoyproxy:release/v1.37from Mar 24, 2026
Merged
Conversation
…oxy#44081) Commit Message: dym: fix a bug where part of body maynot be sent to upstream Additional Description: I have provided two different ABIs (buffered body and received body) to access buffered or latest received body. The the previous legacy addDecodedData and addEncodedData have been unnecessary. Risk Level: low. Testing: unit. Docs Changes: n/a. Release Notes: added. Platform Specific Features: n/a. [Optional Fixes #Issue] To close envoyproxy#43063 --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode
requested review from
agrawroh,
mathetake and
mattklein123
as code owners
Member
|
failure looks real (not sure on cause tho) [1](https://github.com/envoyproxy/envoy/actions/runs/23434473992/job/68168954833#step:19:795)
external/llvm_toolchain_llvm/bin/../include/c++/v1/__memory/allocator_traits.h:305:5: error: no matching function for call to '__construct_at'
305 | std::__construct_at(__p, std::forward<_Args>(__args)...);
| ^~~~~~~~~~~~~~~~~~~ |
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
agrawroh
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dym: fix a bug where part of body maynot be sent to upstream
Additional Description:
I have provided two different ABIs (buffered body and received body) to access buffered or latest received body. The the previous legacy addDecodedData and addEncodedData have been unnecessary.
Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.
[Optional Fixes #Issue] To close
#43063